On Wed, 20 Dec 2006 11:54:23 +0100 Arjan van de Ven <[EMAIL PROTECTED]> wrote:
> On Wed, 2006-12-20 at 02:38 -0800, [EMAIL PROTECTED] wrote: > > The patch titled > > down_write(): preserve local irqs > > has been added to the -mm tree. Its filename is > > down_write-preserve-local-irqs.patch > > > > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find > > out what to do about this > > > > ------------------------------------------------------ > > Subject: down_write(): preserve local irqs > > excuse me? Am I missing something here? Lots. > down_write() is a sleeping function, right? what business does it have > to be *ever* called with irqs off? > > if the answer is "none whatsoever", what good is saving irq state then? > a) this patch is for testers to confirm that this fixes the hangs b) there's plenty of precendent for this - powerpc won't boot if mutex_lock() enables interrupts, for example. We just assume that during early boot these sleeping locks aren't contended. yes, it does suck. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
