On Wed, Dec 23, 2015 at 10:40:38PM +0900, Namhyung Kim wrote: > On Tue, Dec 22, 2015 at 04:43:31PM +0100, Jiri Olsa wrote: > > Implement struct scripting_ops::(process_stat|process_stat_interval) > > handlers - calling scripting handlers from stat events handlers. > > > > Tested-by: Kan Liang <kan.li...@intel.com> > > Link: http://lkml.kernel.org/n/tip-3iu6vmvuur1bntbnh43v3...@git.kernel.org > > Signed-off-by: Jiri Olsa <jo...@kernel.org> > > --- > > tools/perf/builtin-script.c | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > > index a90bc0b81e70..656541eff151 100644 > > --- a/tools/perf/builtin-script.c > > +++ b/tools/perf/builtin-script.c > > @@ -221,6 +221,9 @@ static int perf_evsel__check_attr(struct perf_evsel > > *evsel, > > struct perf_event_attr *attr = &evsel->attr; > > bool allow_user_set; > > > > + if (perf_header__has_feat(&session->header, HEADER_STAT)) > > + return 0; > > + > > allow_user_set = perf_header__has_feat(&session->header, > > HEADER_AUXTRACE); > > > > @@ -674,6 +677,18 @@ static void process_event(struct perf_script *script > > __maybe_unused, union perf_ > > > > static struct scripting_ops *scripting_ops; > > > > +static void process_stat(struct perf_evsel *counter, u64 time) > > +{ > > + if (scripting_ops) > > + scripting_ops->process_stat(&stat_config, counter, time); > > Shouldn't it be > > if (scripting_ops && scripting_ops->process_stat) > > ? It seems you only set it for python in patch 7..
right.. forgot about perf completely.. thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
