On Fri, 2006-12-15 at 22:15 +0100, Heiko Carstens wrote: > This is broken. pgm_check_occured must be volatile, otherwise the -EIO path > in stsch_reset might get optimized away.
That is true, good spotting. Only adding a "volatile" in not the right solution. The point here is that the stsch inline assembly can write to pgm_check_occured. We better tell the compiler, e.g. by adding a "memory" clobber or better a "+m" (pgm_check_occured). For the later we'd have to copy the inline assembly though. -- blue skies, Martin. Martin Schwidefsky Linux for zSeries Development & Services IBM Deutschland Entwicklung GmbH "Reality continues to ruin my life." - Calvin. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
