On Mon, Dec 14, 2015 at 10:39:14AM +0000, Wang Nan wrote: SNIP
> -e, --event <event> event selector. use 'perf list' to list available > events > > # ./perf record -e './test_bpf_map_1.c/xmaps:channel.value=10/' usleep 10 > event syntax error: '..pf_map_1.c/xmaps:channel.value=10/' > \___ Invalid object config option > [SNIP] > > # ./perf record -e './test_bpf_map_1.c/maps:xchannel.value=10/' usleep 10 > event syntax error: '..p_1.c/maps:xchannel.value=10/' > \___ Target map not exist > [SNIP] > > # ./perf record -e './test_bpf_map_1.c/maps:channel.xvalue=10/' usleep 10 > event syntax error: '..ps:channel.xvalue=10/' > \___ Invalid object maps config option > [SNIP] > > # ./perf record -e './test_bpf_map_1.c/maps:channel.value=x10/' usleep 10 > event syntax error: '..nnel.value=x10/' > \___ Incorrect value type for map > [SNIP] > > Change BPF_MAP_TYPE_ARRAY to '1': > > # ./perf record -e './test_bpf_map_1.c/maps:channel.value=10/' usleep 10 > event syntax error: '..ps:channel.value=10/' > \___ Can't use this config term to this > type of map > > Hint: Valid config term: > maps:[<arraymap>].value=[value] > (add -v to see detail) > > Signed-off-by: Wang Nan <wangn...@huawei.com> > Signed-off-by: He Kuang <heku...@huawei.com> > Cc: Alexei Starovoitov <a...@kernel.org> > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > Cc: Jiri Olsa <jo...@kernel.org> > Cc: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Zefan Li <lize...@huawei.com> > Cc: pi3or...@163.com > --- > tools/perf/util/parse-events.c | 56 > +++++++++++++++++++++++++++++++++++++++--- > tools/perf/util/parse-events.h | 3 ++- > tools/perf/util/parse-events.l | 2 +- > tools/perf/util/parse-events.y | 23 ++++++++++++++--- > 4 files changed, 75 insertions(+), 9 deletions(-) I don't understand the bpf stuff, but as far as config terms this change look ok to me, so for bison/flex parser related changes: Acked-by: Jiri Olsa <jo...@kernel.org> thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
