On Thu, 2015-12-10 at 09:49 +0900, Krzysztof Kozlowski wrote: > On 09.12.2015 22:24, Krzysztof Kozlowski wrote: > > W dniu 03.12.2015 o 01:58, Kamal Mostafa pisze: > >> 3.19.8-ckt11 -stable review patch. If anyone has any objections, please > >> let me know. > >> > >> ------------------ > >> > >> From: Krzysztof Kozlowski <[email protected]> > >> > >> commit 824ead03b78403a21449cb7eb153a4344cd3b4c8 upstream. > >> > >> During probe if the regulator could not be enabled, the error exit path > >> would still disable it. This could lead to unbalanced counter of > >> regulator enable/disable. > >> > >> The patch moves code for getting and enabling the regulator from > >> exynos_map_dt_data() to probe function because it is really not a part > >> of getting Device Tree properties. > >> > >> Acked-by: Lukasz Majewski <[email protected]> > >> Tested-by: Lukasz Majewski <[email protected]> > >> Reviewed-by: Alim Akhtar <[email protected]> > >> Signed-off-by: Krzysztof Kozlowski <[email protected]> > >> Fixes: 5f09a5cbd14a ("thermal: exynos: Disable the regulator on probe > >> failure") > >> Signed-off-by: Eduardo Valentin <[email protected]> > >> Signed-off-by: Kamal Mostafa <[email protected]> > >> --- > >> drivers/thermal/samsung/exynos_tmu.c | 33 > >> ++++++++++++++++----------------- > >> 1 file changed, 16 insertions(+), 17 deletions(-) > > > > This patch shouldn't be backported before 4.2. It fixes a bug introduced > > in 4.2: 5f09a5cbd14a. > > > > For kernels <4.2 this bug does not exist but fortunately the patch looks > > harmless. Anyway I think that still it shouldn't be ported for <4.2. > > > > Best regards, > > Krzysztof > > > > Sorry for the noise, I was wrong. Luis pointed out that the 5f09a5cbd14a > was itself backported to 3.19 so this applies to backporting as well.
No worries. Thanks for reviewing this, Krzysztof. -Kamal > No objections from my side. > > Best regards, > Krzysztof > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
