Hello Thomas, On Sun, 6 Dec 2015 10:28:15 +0100 (CET), Thomas Gleixner wrote:
> Second thoughts. That network driver example does not make sense. > > You have a suspend/resume mechanism and a cpu hotplug machinery in > that driver, right? So that should be responsible for > disabling/enabling the per cpu interrupts. I don't think it's the > proper way to do that in the irq chip driver at some random point > during resume as you'd reenable interrupts on cpus which are not > online yet. The irqchip driver would re-enable the per-CPU interrupts in a CPU notifier, so only when the secondary CPUs come online again after resume. When a device driver uses a normal (non per-CPU) interrupt, then it doesn't have to take care of disabling the interrupt on suspend and re-enabling the interrupt on resume at the interrupt controller level. This is all transparently handled by the irqchip driver. Why should the handling of per-CPU interrupts be different and require explicit handling from each device driver rather than being transparently handled by the irqchip driver ? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
