> IS_ERR should address the oops though?? No, see my answer to Jarkko in the other part of the thread.
> I've put all the revised patches here: > > https://github.com/jgunthorpe/linux/commits/for-jarkko > > If you are OK with them now I'll post the series. I haven't re-reviewed it, but the test went alright. As reported before, with "force=1", I get the error message: [ 1351.677808] tpm_tis MSFT0101:00: can't request region for resource [mem 0xfed40000-0xfed44fff] [ 1351.687431] tpm_tis: probe of MSFT0101:00 failed with error -16 This is kind of misleading because the TPM is actually working as a platform device. But I can follow your previous argument that this is acceptable because people who use "force=1" should know what they are doing, so I don't regard this as critical. Martin
