On Wed, Nov 18, 2015 at 12:16:44AM +0300, Yury Norov wrote: > From: Andrew Pinski <apin...@cavium.com> > > Reviewed-by: David Daney <dda...@caviumnetworks.com> > > Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> > Signed-off-by: Christoph Muellner <christoph.muell...@theobroma-systems.com> > Signed-off-by: Yury Norov <yno...@caviumnetworks.com> > Signed-off-by: Andrew Pinski <andrew.pin...@caviumnetworks.com>
Please add a long description to every patch, even if it is trivial. And a nitpick: remove the empty lines between Reviewed-by and Signed-off-by. These tags usually come in the same block. > +#else > + > +typedef elf_greg_t compat_elf_greg_t; > +typedef elf_gregset_t compat_elf_gregset_t; > +#define compat_a32_elf_check_arch(x) 0 > +#define COMPAT_SET_PERSONALITY(ex) > +#define COMPAT_ARCH_DLINFO > + > +#endif Do you need these definitions here? I guess they may be used later by the ILP32 code paths but for A32 compat they don't make much sense (I haven't made it to the end of the series yet). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
