On Saturday 09 December 2006 21:57, Randy Dunlap wrote: > On Sat, 9 Dec 2006 21:50:01 -0500 Dmitry Torokhov wrote: > > > On Saturday 09 December 2006 03:36, Randy Dunlap wrote: > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > > > This driver is an AC97 codec according to its help text. > > > However, if SOUND is disabled, the "select SND_AC97_BUS" > > > still inserts that into the .config file: > > > > > > # > > > # Sound > > > # > > > # CONFIG_SOUND is not set > > > CONFIG_SND_AC97_BUS=m > > > > > > > I consider this abug in kconfig - users of "select" should not know > > full dependency chain for selected symbol. > > Seems that I've heard that somewhere else. > so I agree with that part. > > > > Even if the config software followed dependency chains on selects, > > > we should try to limit usage of "select" to library-type > > > code that is needed (e.g., CRC functions) instead of bus-type > > > support. > > > > > > > I do not agree here - the way our directory structure is laid out > > "sound" comes after "Input device support" menuconfig entry. > > Your patch makes user go back and forth in menuconfig, which is > > awkward. I think using select is fine when an option depends on > > something down the stream. If user already had a chance to select > > necessary option then using "depends on" is preferred. > > Traversing the menus is not difficult. > (It's easier in xconfig or gconfig than menuconfig IMO, > but not a big deal in any of them.) >
I agree but many people use menuconfig and may not even be aware of a driver if it is hidden because facility it depends on is not selected. The same with oldconfig - unless you are closely monitor all changelogs (I for example don't, I just pull from Linus) you would not even get prompted for UCB1400 if you do not have sound enabled. > Anyway, are you saying that the only fix for this build error > is to fix *config to handle select dependencies? > or could propose another way to handle the build error? > Would not adding "select SOUND" fix it? We could use it as a bandaid until kconfig os fixed. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
