On Mon, Nov 23, 2015 at 09:02:49AM +0100, Josef Gajdusek wrote: > This patch adds a driver for the THS clock which is present on the > Allwinner H3. > > Signed-off-by: Josef Gajdusek <a...@atx.name> > ---
Hello Just a minor comment below. > +static void __init sun8i_h3_ths_clk_setup(struct device_node *node) > +{ > + struct clk *clk; > + struct clk_gate *gate; > + struct clk_divider *div; > + const char *parent; > + const char *clk_name = node->name; > + void __iomem *reg; > + int err; > + > + reg = of_io_request_and_map(node, 0, of_node_full_name(node)); > + > + if (IS_ERR(reg)) > + return; > + > + gate = kzalloc(sizeof(*gate), GFP_KERNEL); > + if (!gate) > + goto err_unmap; > + > + div = kzalloc(sizeof(*gate), GFP_KERNEL); copy/paste error, you mean sizeof(*div) ? > + if (!div) > + goto err_gate_free; > + > + of_property_read_string(node, "clock-output-names", &clk_name); Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/