Hi Greg, As you requested [1], I re-worked the tty_debug() macro to format printk output like dev_dbg(), ie., <driver> <tty name>: <fmt>. At the same time, I rolled in Joe's original suggestions [2].
This series also removes the __func__ from tty_debug() since it's redundant when dynamic_debug is enabled (I edited the messages to provide enough context if dynamic_debug is not enabled). The remainder of this series adds tty_*() printk macros (like netdev_*()) and cleans up printk() usage in the tty core. [1] http://www.gossamer-threads.com/lists/linux/kernel/2232363#2232363 [2] http://www.gossamer-threads.com/lists/linux/kernel/2213266#2213266 Regards, Peter Hurley (14): tty: Improve tty_debug() macro tty: Make tty_paranoia_check() file scope tty: synclink_gt: Rename tty_driver_name tty: core: Remove redundant oom message tty: core: Add helper fn to deref tty driver name tty: Define tty_*() printk macros tty: Convert SAK messages to tty_notice() tty: core: Add driver name to invalid device registration message tty: core: Refactor parameters for unset_locked_termios() helper tty: Remove unset_locked_termios() error message tty: core: Prefer pr_* to printk(*) tty: Remove __func__ from tty_debug() macro tty: Merge conditional + error message + WARN_ON() tty: core: Prefer dev_dbg() over pr_debug() drivers/tty/n_tty.c | 7 ++-- drivers/tty/pty.c | 2 +- drivers/tty/synclink_gt.c | 4 +-- drivers/tty/tty_io.c | 86 +++++++++++++++++++++-------------------------- drivers/tty/tty_ioctl.c | 21 ++++-------- drivers/tty/tty_mutex.c | 10 ++---- drivers/tty/tty_port.c | 9 +++-- include/linux/tty.h | 19 +++++++---- 8 files changed, 69 insertions(+), 89 deletions(-) -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
