On 02.11.2015 21:56, Daniel Lezcano wrote: > Let the platform's Kconfig to select the clock instead of having a reverse > dependency from the driver to the platform options.
Selecting user-visible symbols is rather discouraged so why not something like this: - def_bool y if ARCH_EXYNOS - depends on !ARM64 + bool "Exynos multi core timer driver" + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) Best regards, Krzysztof > > Add the COMPILE_TEST option for the compilation test coverage. Due to the > non portable 'delay' code, this driver is only compilable on ARM. > > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> > --- > arch/arm/mach-exynos/Kconfig | 1 + > drivers/clocksource/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 3a10f1a..ff10539 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select SRAM > select THERMAL > select MFD_SYSCON > + select CLKSRC_EXYNOS_MCT > help > Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 916c36d..d829cbe 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC > This option enables support for the Meta per-thread timers. > > config CLKSRC_EXYNOS_MCT > - def_bool y if ARCH_EXYNOS > - depends on !ARM64 > + bool "Exynos multi core timer driver" if COMPILE_TEST > + depends on ARM > help > Support for Multi Core Timer controller on Exynos SoCs. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
