On Mon, Nov 02, 2015 at 12:10:25PM +0100, Jiri Olsa wrote: > If machine's thread gets excited (EXIT event is received),
Why a thread get *excited* when it received EXIT event? :) > we set thread->dead = true and it is later on removed from > machine's tree if the pid is reused on new thread. > > The latency subcommand holds tree of working atoms sorted > by thread's pid/tid. If there's new thread with same pid > and tid, the old working atom is found and assert bug > condition is hit in search function: > > thread_atoms_search: Assertion `!(thread != atoms->thread)' failed > > Changing the sort function to use thread object pointers > together with pid and tid check. This way new thread will > never find old one with same pid/tid. > > I think we could change this to the sort based on timestamp > of thread creation, once it's added within Namhyung's thread > patchset. Right. I'll work on the v6 soon. As a work around: Acked-by: Namhyung Kim <namhy...@kernel.org> Thanks, Namhyung > > Reported-by: Mohit Agrawal <moagr...@redhat.com> > Link: http://lkml.kernel.org/n/tip-o4doazhhv0zax5zshkg8h...@git.kernel.org > Signed-off-by: Jiri Olsa <jo...@kernel.org> > --- > tools/perf/builtin-sched.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index 0ee6d900e100..e3d3e32c0a93 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -1203,12 +1203,13 @@ static void output_lat_thread(struct perf_sched > *sched, struct work_atoms *work_ > > static int pid_cmp(struct work_atoms *l, struct work_atoms *r) > { > + if (l->thread == r->thread) > + return 0; > if (l->thread->tid < r->thread->tid) > return -1; > if (l->thread->tid > r->thread->tid) > return 1; > - > - return 0; > + return (int)(l->thread - r->thread); > } > > static int avg_cmp(struct work_atoms *l, struct work_atoms *r) > -- > 2.4.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
