On Mon, 4 Dec 2006, Matthew Wilcox wrote:
>
> You're right. It hasn't actually caused any problems, presumably due to
> linux/types.h being included absolutely everywhere already, but it's
> clearly the Right Thing To Do. Updated patch:
I'm still not happy.
The return value of "hash_u64()" had better be u64, not "unsigned long".
Same goes (to a smaller degree) for hash_u32().
I can trivially just edit the patch and fix these things, but with two
bugs found by just inspection of the patch, I'm going to ask you to look
it over one more time and re-send me a "guaranteed correct" version, ok?
Because I'm a very religious man, and my religion basically boils down to
"If somebody else can do it for me, they should. I'm lazy, and I like it
that way. Besides, next time maybe they'll double-check on their own".
Thanks. And please spread the Good Word.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
