On 26/10/15 13:41, Wang Nan wrote: > evsel->system_wide is introduced by commit bf8e8f4b832972c76d64ab2e2837 > (perf evlist: Add 'system_wide' option), which is used for mixing evsels > that aren't system-wide with ones that are [1]. However, for global > system wide recording (perf record -a ...), evsel->system_wide is set > to false, which is confusion. > > This patch set evsel->system_wide to true if the target.system_wide is > set, which makes evsel->system_wide a reliable way to describe whether > itself is system_wide or not. > > [1] http://lkml.kernel.org/r/562df19b.2080...@intel.com > > Signed-off-by: Wang Nan <wangn...@huawei.com> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: Arnaldo Carvalho de Melo <a...@redhat.com> > Cc: Alexei Starovoitov <a...@plumgrid.com> > Cc: Peter Zijlstra <a.p.zijls...@chello.nl> > Cc: Li Zefan <lize...@huawei.com> > Cc: pi3or...@163.com > Link: http://lkml.kernel.org/n/ebpf-qm3gtwidc1o5ktjd9tgje...@git.kernel.org > --- > tools/perf/util/evsel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 3ac4ee9c..36ecf0e 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -734,6 +734,7 @@ void perf_evsel__config(struct perf_evsel *evsel, struct > record_opts *opts) > int track = evsel->tracking; > bool per_cpu = opts->target.default_per_cpu && !opts->target.per_thread; > > + evsel->system_wide = opts->target.system_wide;
Well that breaks the way evsel->system_wide is used i.e. it is a parameter to the evsel and here you just overwrote it. > attr->sample_id_all = perf_missing_features.sample_id_all ? 0 : 1; > attr->inherit = !opts->no_inherit; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
