Hi Markus, s/mm-commits/lkml/
On 10/24, Markus Pargmann wrote: > > On Mon, Oct 05, 2015 at 02:19:27PM -0700, a...@linux-foundation.org wrote: > > > > Subject: signal: turn dequeue_signal_lock() into kernel_dequeue_signal() > > > > 1. Rename dequeue_signal_lock() to kernel_dequeue_signal(). This > > matches another "for kthreads only" kernel_sigaction() helper. > > > > 2. Remove the "tsk" and "mask" arguments, they are always current > > and current->blocked. And it is simply wrong if tsk != current. > > > > 3. We could also remove the 3rd "siginfo_t *info" arg but it looks > > potentially useful. However we can simplify the callers if we > > change kernel_dequeue_signal() to accept info => NULL. > > > > 4. Remove _irqsave, it is never called from atomic context. > > I just realised that this patch will conflict with a fixup patch for nbd > that will be included in rc7. > > dcc909d90ccd (nbd: Add locking for tasks) > > I think there is basically one new instance of dequeue_signal_lock() that > needs to be replaced with kernel_dequeue_signal(). Thanks! I'll send *-fix.patch to Andrew. But you know, dcc909d90ccd (nbd: Add locking for tasks) doesn't look exactly right at first glance, although I need to re-check tomorrow... One question, can sock_xmit() be called from user space? Or it is only called by kthreads? Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
