Hans, On Tue, 10 Oct 2006 11:18:33 +0200, Hans de Goede wrote: > Jean Delvare wrote: > > The patch isn't wrong per se, but it could be made more simple, and is > > incomplete in comparison to what was done for all other hardware > > monitoring drivers: > > > > * We want to create all the files before registering with the hwmon > > class, this closes a race condition. > > * We want to delete all the device files at regular cleanup time (after > > unregistering with the hwmon class). > > * It's OK to call device_remove_file() on a non-existent file, so the > > error path can be simplified. > > > > I'd like the abituguru driver to behave the same as all other hardware > > monitoring drivers to lower the maintenance effort. Can either you > > or Jeff work up a compliant patch? > > I understand Jeff any chance you can do a new revision of > your patch? Otherwise I'll take care of it as time permits.
I'm still waiting for this patch. It'd be nice to have the abituguru driver fixed in 2.6.20. Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
