On Thu 28 Sep 2000, Luca Montecchiani wrote:

> Init function for hisax driver cause a kernel hangup if the
> idstring was omitted

Good catch.

> -       if (strlen(str)) {
> +       if (str) {

I'd make this:

+       if (str && *str) {

to preserve the intention of the original code
(the string mustn't be empty).

> -       if (strlen(str)) {
> +       if (str) {

ditto


Paul Slootman
-- 
home:       [EMAIL PROTECTED] http://www.wurtel.demon.nl/
work:       [EMAIL PROTECTED]       http://www.murphy.nl/
debian:     [EMAIL PROTECTED]      http://www.debian.org/
isdn4linux: [EMAIL PROTECTED]   http://www.isdn4linux.de/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/

Reply via email to