Hi Michael,
It is better to assume that he has done the checks and then do the checks
to convince yourself (as they say in russia "doverjaj no proverjaj" -
"trust but always double-check").
So, I now went fs/ext2/ialloc.c and did that for you - ext2_new_inode()
does indeed set err accordingly and amongst its possible returns, there is
infact EDQUOT.
Regards,
Tigran
On Fri, 1 Sep 2000, Dr. Michael Weller wrote:
> Sorry, I've no idea about the ext2 and fs implementation.
> However did you read the comment below and convince yourself that 'err' is
> always set correctly?
>
> I'm just asking because you don't mention it and no patch to
> ext2_new_inode that makes it set err correctly is provided. It could be
> the comment was wrong, but I doubt it. This gives me the odd feeling that
> you are fixing things in the wrong place and add new bugs. Please check
> that.
>
> Also, I might be wrong, but maybe you should submit things to Alan, not
> Linus, could be it suffices to post them here though.
>
> Michael.
>
> .... cite from your patch: ...
> /*
> - * N.B. Several error exits in ext2_new_inode don't set err.
> + * Errors like EDQUOT can happen...
> */
>
>
> --
>
> Michael Weller: [EMAIL PROTECTED], [EMAIL PROTECTED],
> or even [EMAIL PROTECTED] If you encounter an eowmob account on
> any machine in the net, it's very likely it's me.
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> Please read the FAQ at http://www.tux.org/lkml/
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
