On 29-Aug-2000 Ingo Molnar wrote:

> i agree fully. The attached patch against test8-pre1 changes
> schedule_idle() from inline to FASTCALL - things look much nicer with this
> one applied.
>
> -static inline void reschedule_idle(struct task_struct * p, unsigned long
flags)
> +static FASTCALL(void reschedule_idle(struct task_struct *, unsigned long));

You can't do this.  SPARC requires you to restore the flags in the same
function where you saved them because they contain register window status. 
You *have* to inline the part that drops the run queue lock.  The bulk of the
function though doesn't need to be inlined.  See how it is done in my
scheduler patch.

-- 
Dimitris Michailidis                    [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/

Reply via email to