On Wed, Mar 19, 2025 at 08:44:22PM -0300, Jason Gunthorpe wrote: > On Tue, Mar 18, 2025 at 05:18:53PM +0100, Stefano Garzarella wrote: > > > I see, thanks for the clarification! > > I saw that with devm_get_free_pages() I can easily allocate a > > resource-managed page, so I'll do that in v4. > > As a general note you should just use kmalloc these days, even for > PAGE_SIZE. It is efficient and OK. > > Having a struct that is PAGE_SIZE+1 is not efficient and will waste > a page of memory. That should be avoided ..
Yeah, kzalloc() takes care of this magic. As said, kzalloc() vs alloc_page() is not an existential question for this patch set :-) I just would personally use alloc_page(). If nothing else, it does have some super cosmetic benefits e.g., thinner call stack (when needing to debug deep, which sometimes happens). > > Jason > BR, Jarkko
