Hi Sumit, Jens,

On Thu, Mar 13, 2025 at 01:59:19PM +0100, Jens Wiklander wrote:
On Thu, Mar 13, 2025 at 10:13 AM Sumit Garg <sumit.g...@kernel.org> wrote:

+ Jens

Hi Stefano,

On Tue, Mar 11, 2025 at 11:01:29AM +0100, Stefano Garzarella wrote:
> This driver does not support interrupts, and receiving the response is
> synchronous with sending the command.
>
> It used an internal buffer to cache the response when .send() is called,
> and then return it when .recv() is called.
>
> Let's simplify the driver by implementing the new send_recv() op, so that
> we can also remove the 4KB internal buffer used to cache the response.

Looks like a nice cleanup to me but it needs to be tested. Jens, can you
give this patch a try?

>
> Signed-off-by: Stefano Garzarella <sgarz...@redhat.com>
> ---
> Note: I don't know how to test this driver, so I just build it.
> If someone can test it, or tell me how to do, it will be great!

Tested-by: Jens Wiklander <jens.wiklan...@linaro.org>


Thanks for testing this!

Cheers,
Jens


The fTPM is now maintained as part of OP-TEE project here [1]. The
instructions to test it on Qemu can be found here [2] as part of CI
pipeline.

[1] https://github.com/OP-TEE/optee_ftpm
[2] https://github.com/OP-TEE/optee_ftpm/blob/master/.github/workflows/ci.yml


Thanks for the links, I'll take a look!

Stefano


Reply via email to