On Tue May 21, 2024 at 8:59 PM EEST, Matt Ochs wrote: > > On May 21, 2024, at 10:55 AM, Jarkko Sakkinen <[email protected]> wrote: > >> > >> /* > >> * TCG SPI flow control is documented in section 6.4 of the spec[1]. In > >> short, > >> @@ -247,7 +249,7 @@ static int tpm_tis_spi_write_bytes(struct tpm_tis_data > >> *data, u32 addr, > >> int tpm_tis_spi_init(struct spi_device *spi, struct tpm_tis_spi_phy *phy, > >> int irq, const struct tpm_tis_phy_ops *phy_ops) > >> { > >> - phy->iobuf = devm_kmalloc(&spi->dev, MAX_SPI_FRAMESIZE, GFP_KERNEL); > >> + phy->iobuf = devm_kmalloc(&spi->dev, MAX_SPI_BUFSIZE, GFP_KERNEL); > > > > It would better to open code here "SPI_HDRSIZE + MAX_SPI_FRAMESIZE". > > > > I.e. less cross-referencing and documents better what is going on at > > the call site. > > Sure, will make this change in a v2.
Yeah, and thanks for spotting the bug and fixing it! Looking forward to the final fix. BR, Jarkko
