Instead of relying on a global static "hash_algo" variable, which is not
concurrency-safe, update the imaevm_verify_hash() function definition
and callers to include a "hash_algo" parameter as a place holder.

Now with the "hash_algo" parameter, export the imaevm_verify_hash()
definition.

Signed-off-by: Mimi Zohar <zo...@linux.ibm.com>
---
 src/imaevm.h    |  3 +++
 src/libimaevm.c | 13 +++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/imaevm.h b/src/imaevm.h
index b29a4745fc77..99987140c278 100644
--- a/src/imaevm.h
+++ b/src/imaevm.h
@@ -248,6 +248,9 @@ uint32_t imaevm_read_keyid(const char *certfile);
 
 int sign_hash(const char *algo, const unsigned char *hash, int size, const 
char *keyfile, const char *keypass, unsigned char *sig);
 int verify_hash(const char *file, const unsigned char *hash, int size, 
unsigned char *sig, int siglen);
+int imaevm_verify_hash(void *public_keys, const char *file,
+                      const char *hash_algo, const unsigned char *hash,
+                      int size, unsigned char *sig, int siglen);
 int ima_verify_signature(const char *file, unsigned char *sig, int siglen, 
unsigned char *digest, int digestlen);
 int ima_verify_signature2(void *public_keys, const char *file,
                          unsigned char *sig, int siglen,
diff --git a/src/libimaevm.c b/src/libimaevm.c
index 6fecb2ffd139..eeffe97ec8ea 100644
--- a/src/libimaevm.c
+++ b/src/libimaevm.c
@@ -729,8 +729,8 @@ int imaevm_hash_algo_from_sig(unsigned char *sig)
 }
 
 int imaevm_verify_hash(void *public_keys, const char *file,
-                      const unsigned char *hash, int size,
-                      unsigned char *sig, int siglen)
+                      const char *hash_algo, const unsigned char *hash,
+                      int size, unsigned char *sig, int siglen)
 {
        /* Get signature type from sig header */
        if (sig[1] == DIGSIG_VERSION_1) {
@@ -762,7 +762,8 @@ __attribute__((deprecated)) int verify_hash(const char 
*file,
                                            const unsigned char *hash, int size,
                                            unsigned char *sig, int siglen)
 {
-       return imaevm_verify_hash(g_public_keys, file, hash, size, sig, siglen);
+       return imaevm_verify_hash(g_public_keys, file, NULL, hash, size,
+                                 sig, siglen);
 }
 
 int ima_verify_signature2(void *public_keys, const char *file,
@@ -795,15 +796,15 @@ int ima_verify_signature2(void *public_keys, const char 
*file,
         * measurement list, not by calculating the local file digest.
         */
        if (digest && digestlen > 0)
-               return imaevm_verify_hash(public_keys, file, digest, digestlen,
-                                         sig, siglen);
+               return imaevm_verify_hash(public_keys, file, NULL, digest,
+                                         digestlen, sig, siglen);
 
        hashlen = ima_calc_hash(file, hash);
        if (hashlen <= 1)
                return hashlen;
        assert(hashlen <= sizeof(hash));
 
-       return imaevm_verify_hash(public_keys, file, hash, hashlen,
+       return imaevm_verify_hash(public_keys, file, NULL, hash, hashlen,
                                  sig, siglen);
 }
 
-- 
2.39.3


Reply via email to