Could you please trim your replies. In long patches like this not doing so makes for a huge fishing expedition
On Sun, 2023-11-26 at 05:45 +0200, Jarkko Sakkinen wrote: [...] > > Most the code looks overally decent, except reverse christmas tree > > declarations would be nice to have. Getting this patch right is > > probably the most critical and rest is pretty easy after that. > > Thus the focus. > > I'll consider picking the tail, editing minimally and sending a new > version with the hmac patches. I.e. change the config flag name and > stuff like that. I already have it converted ... that's how I found the bugs I reported, but I need a stable base for a repost. James
