On Tue, 13 Nov 2001, James Cameron wrote: > G'day mulix,
good day, james. > Thank you for your patch to pptp that adds support for Bezeq. thank you for maintaining pptp and thanks to the original author, for writing it. > - I'm wondering if the #define should be something other than Bezeq. > Have you heard if any other implementations need this change? Have you > any idea what software or hardware Bezeq is using to deliver ADSL? no idea, but i think dani answered this point. > - can this code change be added as a configuration option rather than an > #ifdef? probably... i'll grab the latest pptp cvs source and make a patch later today. > - changes are made to pptp_options.h for Bezeq, but some of them are > ignored by the struct pptp_out_call_rqst packet changes. Would it be > possible to define additional constants so that the code that > initialises the struct has no #ifdef? In other words, can the changes > be isolated somehow in order to simplify the code. would generating the packet at run time, based on the user supplied command line options, be acceptable? something like struct pptp_out_call_rqst packet; build_call_rqst_packet(&packet); where build_call_rqst_packet would build the correct packet, based on whether the user supplied --bezeq or not. this deviates from the common style in the code for packet construction, which is the reason i didnt do it in the first place. > - do the changes to add pptp_set_link need to be #ifdef'd? Has this > been tested with conventional PPTP environments? since the only pptp environment i have is bezeq's adsl service, it hasnt. i wrote this specific bit of the patch, based on packet dumps of windows boxes. i remember set_link is defined in the rfc, but i dont think it's required. it's been a while since i read the rfc, though. > - the changes to the error reporting are good, they improve the > situation. good, that was the first thing we did ;) > Patch relative to current CVS is attached. No significant changes made, > just made sure it applies cleanly. thanks. -- mulix http://www.pointer.co.il/~mulix/ http://syscalltrack.sf.net/ ================================================================= To unsubscribe, send mail to [EMAIL PROTECTED] with the word "unsubscribe" in the message body, e.g., run the command echo unsubscribe | mail [EMAIL PROTECTED]
