James, As one of the people that were involved in integrating support for Bezeq ADSL I would like to answer one of your questions.
On Tue, 13 Nov 2001, James Cameron wrote: > G'day mulix, > > - I'm wondering if the #define should be something other than Bezeq. > Have you heard if any other implementations need this change? Have you > any idea what software or hardware Bezeq is using to deliver ADSL? > Bezeq are using common hardware: Orckit and Alcatel units. During debuging the different models pptp sessions we found a few bugs in the pptp implemetation at the ADSL modem side. Some of the patches are aimed to bypass these bugs. So the answer is that it will probably solve problem with other ISPs using the same equipment. On the other hand, once implemented, the pptp is not fully compatible with the RFC . Maybe it would make sense to make a #define per ADSL modem that is bugy. > - can this code change be added as a configuration option rather than an > #ifdef? I think it would be possible. something like "MS windowns compatibility mode" ... > > - changes are made to pptp_options.h for Bezeq, but some of them are > ignored by the struct pptp_out_call_rqst packet changes. Would it be > possible to define additional constants so that the code that > initialises the struct has no #ifdef? In other words, can the changes > be isolated somehow in order to simplify the code. > > - do the changes to add pptp_set_link need to be #ifdef'd? Has this > been tested with conventional PPTP environments? > > - the changes to the error reporting are good, they improve the > situation. > > Patch relative to current CVS is attached. No significant changes made, > just made sure it applies cleanly. > > -- > James Cameron > http://quozl.linux.org.au/ Dani ================================================================= To unsubscribe, send mail to [EMAIL PROTECTED] with the word "unsubscribe" in the message body, e.g., run the command echo unsubscribe | mail [EMAIL PROTECTED]
