On Wed, Jul 01, 2026, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) > to consider: > > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c > > index aa1e19979aa8e..8d3d930576fd7 100644 > > --- a/arch/x86/kernel/apic/apic.c > > +++ b/arch/x86/kernel/apic/apic.c > > [ ... ] > > > @@ -796,6 +796,16 @@ bool __init apic_needs_pit(void) > > return lapic_timer_period == 0; > > } > > > > +void apic_set_timer_period_khz(u64 period_khz, const char *source) > > +{ > > + lapic_timer_period = mul_u64_u32_div(period_khz, 1000, HZ); > > +} > > + > > +void apic_set_timer_period_hz(u64 period_hz, const char *source) > > +{ > > + lapic_timer_period = div_u64(period_hz, HZ); > > +} > > [Severity: Medium] > It looks like the source parameter is accepted by apic_set_timer_period_khz() > and apic_set_timer_period_hz() in arch/x86/kernel/apic/apic.c but is never > used. Was it intended to log the frequency using this source string?
/facepalm, yes.
