> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Friday, January 2, 2026 7:12 PM
> To: Haiyang Zhang <[email protected]>
> Cc: [email protected]; [email protected]; KY Srinivasan
> <[email protected]>; Haiyang Zhang <[email protected]>; Wei Liu
> <[email protected]>; Dexuan Cui <[email protected]>; Andrew Lunn
> <[email protected]>; David S. Miller <[email protected]>; Eric
> Dumazet <[email protected]>; Paolo Abeni <[email protected]>; Long Li
> <[email protected]>; Konstantin Taranov <[email protected]>;
> Simon Horman <[email protected]>; Erni Sri Satya Vennela
> <[email protected]>; Shradha Gupta
> <[email protected]>; Saurabh Sengar
> <[email protected]>; Aditya Garg
> <[email protected]>; Dipayaan Roy
> <[email protected]>; Shiraz Saleem
> <[email protected]>; [email protected]; linux-
> [email protected]; Paul Rosswurm <[email protected]>
> Subject: [EXTERNAL] Re: [PATCH net-next, 1/2] net: mana: Add support for
> coalesced RX packets on CQE
>
> On Fri, 2 Jan 2026 13:35:57 -0800 Haiyang Zhang wrote:
> > + NL_SET_ERR_MSG_FMT(extack, "Set rx-frames to %u failed:%d\n",
> > + ec->rx_max_coalesced_frames, err);
>
> No trailing new line in extack messages, please.
> Also please do not duplicate the err value in the message itself,
> it's already passed to user space. Well behaved user space will format
> this as eg:
>
> Set rx-frames to 123 failed:-11: Invalid argument
I will update the patch.
Thanks,
- Haiyang
