> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Friday, May 16, 2025 9:05 PM
> To: Haiyang Zhang <haiya...@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org; net...@vger.kernel.org; Dexuan Cui
> <de...@microsoft.com>; step...@networkplumber.org; KY Srinivasan
> <k...@microsoft.com>; Paul Rosswurm <paul...@microsoft.com>;
> o...@aepfle.de; vkuzn...@redhat.com; da...@davemloft.net;
> wei....@kernel.org; eduma...@google.com; pab...@redhat.com;
> l...@kernel.org; Long Li <lon...@microsoft.com>;
> ssen...@linux.microsoft.com; linux-r...@vger.kernel.org;
> dan...@iogearbox.net; john.fastab...@gmail.com; b...@vger.kernel.org;
> a...@kernel.org; h...@kernel.org; t...@linutronix.de;
> shradhagu...@linux.microsoft.com; andrew+net...@lunn.ch; Konstantin
> Taranov <kotara...@microsoft.com>; ho...@kernel.org; linux-
> ker...@vger.kernel.org
> Subject: [EXTERNAL] Re: [PATCH net-next,v4] net: mana: Add handler for
> hardware servicing events
>
> On Wed, 14 May 2025 13:30:37 -0700 Haiyang Zhang wrote:
> > + dev_info(gc->dev, "Start MANA service type:%d\n", type);
> > + gc->in_service = true;
> > + mns_wk->pdev = to_pci_dev(gc->dev);
> > + INIT_WORK(&mns_wk->serv_work, mana_serv_func);
> > + schedule_work(&mns_wk->serv_work);
>
> I don't see any refcounting in this patch, and the work is not
> canceled. What if the device is removed between work being scheduled
> and running?
Thanks for the review. I added refcnt handling, and submitted a new
patch.
- Haiyang
