On 4/24/2025 7:18 PM, Michael Kelley wrote:
From: Naman Jain <namj...@linux.microsoft.com> Sent: Wednesday, April 23, 2025
10:35 PM
Hi,
This patch series aims to address the sysfs creation issue for the ring
buffer by reorganizing the code. Additionally, it updates the ring sysfs
size to accurately reflect the actual ring buffer size, rather than a
fixed static value.
PFB change logs:
Changes since v5:
https://lore.kernel.org/all/20250415164452.170239-1-namj...@linux.microsoft.com/
* Added Reviewed-By tags from Dexuan. Also, addressed minor comments in
commit msg of both patches.
* Missed to remove check for "primary_channel->device_obj->channels_kset" in
hv_create_ring_sysfs in earlier patch, as suggested by Michael. Did it
now.
Ah, OK :-) I thought you had decided to leave the test in, and I wasn't going to
argue further, as it didn't hurt anything. But the test is superfluous, so the
code is better without it. It won't mislead a future someone into thinking
that it solves a synchronization problem.
Michael
I agree :D
Regards,
Naman
* Changed type for declaring bin_attrs due to changes introduced by
commit 9bec944506fa ("sysfs: constify attribute_group::bin_attrs") which
merged recently. Did not use bin_attrs_new since another change is in
the queue to change usage of bin_attrs_new to bin_attrs
(sysfs: finalize the constification of 'struct bin_attribute').
