On Wed, Apr 16, 2025 at 01:32:49PM -0500, Bjorn Helgaas wrote: > On Wed, Apr 16, 2025 at 08:36:21AM -0700, Shradha Gupta wrote: > > Currently, the MANA driver allocates pci vector statically based on > > MANA_MAX_NUM_QUEUES and num_online_cpus() values and in some cases ends > > up allocating more vectors than it needs. > > This is because, by this time we do not have a HW channel and do not know > > how many IRQs should be allocated. > > To avoid this, we allocate 1 IRQ vector during the creation of HWC and > > after getting the value supported by hardware, dynamically add the > > remaining vectors. > > Add blank lines between paragraphs. > > s/pci vector/MSI-X vectors/ > > Maybe also update subject to mention "MSI-X vectors" instead of "PCI > vector", since "PCI vector" is not really a common term.
Understood, thanks Bjorn.