On 3/26/2025 7:56 AM, Rafael J. Wysocki wrote:
On Sat, Mar 15, 2025 at 1:19 AM Roman Kisel <rom...@linux.microsoft.com> wrote:
[...]
- chip_data);
+#ifdef CONFIG_ACPI
+ if (!acpi_disabled)
+ irq_domain_parent = hv_pci_acpi_irq_domain_parent();
+#endif
+#if defined(CONFIG_OF)
Why don't you do
#ifdef CONFIG_OF
here for consistency?
Agree, that'd be easier on the eyes :) Will fix in the next version,
thanks for the suggestion!
+ if (!irq_domain_parent)
+ irq_domain_parent = hv_pci_of_irq_domain_parent();
+#endif
+ if (!irq_domain_parent) {
+ WARN_ONCE(1, "Invalid firmware configuration for VMBus
interrupts\n");
+ ret = -EINVAL;
+ goto free_chip;
+ }
+
+ hv_msi_gic_irq_domain = irq_domain_create_hierarchy(
+ irq_domain_parent, 0, HV_PCI_MSI_SPI_NR,
+ fn, &hv_pci_domain_ops,
+ chip_data);
if (!hv_msi_gic_irq_domain) {
pr_err("Failed to create Hyper-V arm64 vPCI MSI IRQ domain\n");
--
--
Thank you,
Roman
