> -----Original Message-----
> From: Andrew Lunn <and...@lunn.ch>
> Sent: Tuesday, March 25, 2025 3:59 PM
> To: Haiyang Zhang <haiya...@microsoft.com>
> Cc: Jakub Kicinski <k...@kernel.org>; Erni Sri Satya Vennela
> <er...@linux.microsoft.com>; KY Srinivasan <k...@microsoft.com>;
> wei....@kernel.org; Dexuan Cui <de...@microsoft.com>;
> andrew+net...@lunn.ch; da...@davemloft.net; eduma...@google.com;
> pab...@redhat.com; Long Li <lon...@microsoft.com>; Konstantin Taranov
> <kotara...@microsoft.com>; ho...@kernel.org; brett.cree...@amd.com;
> sur...@google.com; schakraba...@linux.microsoft.com;
> kent.overstr...@linux.dev; shradhagu...@linux.microsoft.com;
> erick.arc...@outlook.com; ros...@gmail.com; linux-hyperv@vger.kernel.org;
> net...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-
> r...@vger.kernel.org; Paul Rosswurm <paul...@microsoft.com>
> Subject: Re: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement
> set_link_ksettings in ethtool for speed
>
> > This patch is just to support the ethtool option for the speed.
> > And seems there is no option on ethtool to reset NIC to the default
> > speed?
>
> There is no such thing as default speed. Speed is either:
>
> 1) Negotiated with the link partner, picking the highest speed link
> modes both partners support
>
> 2) Forced to a specific speed, based on one of the link modes the
> interfaces supports.
>
> Since you don't have link modes, you are abusing the API. You should
> choose a different API which actually fits what you are doing,
> configuring a leaky bucket shaper.
>
Could you please point us to the interface struct, callback function
names, and/or docs you are suggesting us to use?
Thanks,
- Haiyang
