On Sun, Mar 09, 2025 at 10:01:33PM +0000, Haiyang Zhang wrote:
>
>
> > -----Original Message-----
> > From: Jakub Kicinski <[email protected]>
> > Sent: Friday, March 7, 2025 10:50 PM
> > To: Haiyang Zhang <[email protected]>
> > Cc: [email protected]; [email protected]; Dexuan Cui
> > <[email protected]>; [email protected]; KY Srinivasan
> > <[email protected]>; Paul Rosswurm <[email protected]>;
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; Long Li <[email protected]>;
> > [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected];
> > [email protected]
> > Subject: [EXTERNAL] Re: [PATCH net] net: mana: Support holes in device
> > list reply msg
> >
> > On Wed, 5 Mar 2025 13:46:21 -0800 Haiyang Zhang wrote:
> > > - for (i = 0; i < max_num_devs; i++) {
> > > + for (i = 0; i < GDMA_DEV_LIST_SIZE &&
> > > + found_dev < resp.num_of_devs; i++) {
> >
> > unfortunate mis-indent here, it blend with the code.
> > checkpatch is right that it should be aligned with opening bracket
> Will fix it.
>
> >
> > > dev = resp.devs[i];
> > > dev_type = dev.type;
> > >
> > > + /* Skip empty devices */
> > > + if (dev.as_uint32 == 0)
> > > + continue;
> > > +
> > > + found_dev++;
> > > + dev_info(gc->dev, "Got devidx:%u, type:%u, instance:%u\n", i,
> > > + dev.type, dev.instance);
> >
> > Are you sure you want to print this info message for each device,
> > each time it's probed? Seems pretty noisy. We generally recommend
> > printing about _unusual_ things.
> Ok. I can remove it.
How about a dev_dbg instead?
>
> Thanks,
> - Haiyang
