Using guard notation makes the code more compact and error handling
more robust by ensuring that serio ports are resumed in all code paths
when control leaves critical section.

Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>
---
 drivers/input/mouse/byd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/mouse/byd.c b/drivers/input/mouse/byd.c
index 221a553f45cd..654b38d249f3 100644
--- a/drivers/input/mouse/byd.c
+++ b/drivers/input/mouse/byd.c
@@ -254,13 +254,12 @@ static void byd_clear_touch(struct timer_list *t)
        struct byd_data *priv = from_timer(priv, t, timer);
        struct psmouse *psmouse = priv->psmouse;
 
-       serio_pause_rx(psmouse->ps2dev.serio);
+       guard(serio_pause_rx)(psmouse->ps2dev.serio);
+
        priv->touch = false;
 
        byd_report_input(psmouse);
 
-       serio_continue_rx(psmouse->ps2dev.serio);
-
        /*
         * Move cursor back to center of pad when we lose touch - this
         * specifically improves user experience when moving cursor with one
-- 
2.46.0.469.g59c65b2a67-goog


Reply via email to