Re: [PATCH net-next] net: mana: Use mana_cleanup_port_context() for rxq cleanup

[Heng Qi]

在 2024/6/14 下午3:19, Shradha Gupta 写道:

To cleanup rxqs in port context structures, instead of duplicating the
code, use existing function mana_cleanup_port_context() which does
the exact cleanup that's needed.

Signed-off-by: Shradha Gupta <shradhagu...@linux.microsoft.com>
---
  drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c 
b/drivers/net/ethernet/microsoft/mana/mana_en.c
index b89ad4afd66e..93e526e5dd16 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2529,8 +2529,7 @@ static int mana_init_port(struct net_device *ndev)
        return 0;

reset_apc:

-       kfree(apc->rxqs);
-       apc->rxqs = NULL;
+       mana_cleanup_port_context(apc);
        return err;
  }

@@ -2787,8 +2786,7 @@ static int mana_probe_port(struct mana_context *ac, int port_idx,

  free_indir:
        mana_cleanup_indir_table(apc);
  reset_apc:
-       kfree(apc->rxqs);
-       apc->rxqs = NULL;
+       mana_cleanup_port_context(apc);
  free_net:
        *ndev_storage = NULL;
        netdev_err(ndev, "Failed to probe vPort %d: %d\n", port_idx, err);

Reviewed-by: Heng Qi <hen...@linux.alibaba.com>

Thanks!