> -----Original Message-----
> From: justinst...@google.com <justinst...@google.com>
> Sent: 2023年12月7日 7:16
> To: David S. Miller <da...@davemloft.net>; Eric Dumazet
> <eduma...@google.com>; Jakub Kicinski <k...@kernel.org>; Paolo Abeni
> <pab...@redhat.com>; Shay Agroskin <shay...@amazon.com>; Arthur
> Kiyanovski <akiy...@amazon.com>; David Arinzon
> <darin...@amazon.com>; Noam Dagan <nda...@amazon.com>; Saeed
> Bishara <sae...@amazon.com>; Rasesh Mody <rm...@marvell.com>;
> Sudarsana Kalluru <skall...@marvell.com>; gr-linux-nic-...@marvell.com;
> Dimitris Michailidis <dmich...@fungible.com>; Yisen Zhuang
> <yisen.zhu...@huawei.com>; Salil Mehta <salil.me...@huawei.com>; Jesse
> Brandeburg <jesse.brandeb...@intel.com>; Tony Nguyen
> <anthony.l.ngu...@intel.com>; Louis Peens <louis.pe...@corigine.com>;
> Shannon Nelson <shannon.nel...@amd.com>; Brett Creeley
> <brett.cree...@amd.com>; driv...@pensando.io; K. Y. Srinivasan
> <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>; Wei Liu
> <wei....@kernel.org>; Dexuan Cui <de...@microsoft.com>; Ronak Doshi
> <dos...@vmware.com>; VMware PV-Drivers Reviewers
> <pv-driv...@vmware.com>; Andy Whitcroft <a...@canonical.com>; Joe
> Perches <j...@perches.com>; Dwaipayan Ray <dwaipayanr...@gmail.com>;
> Lukas Bulwahn <lukas.bulw...@gmail.com>; Hauke Mehrtens
> <ha...@hauke-m.de>; Andrew Lunn <and...@lunn.ch>; Florian Fainelli
> <f.faine...@gmail.com>; Vladimir Oltean <olte...@gmail.com>; Arınç ÜNAL
> <arinc.u...@arinc9.com>; Daniel Golle <dan...@makrotopia.org>; Landen
> Chao <landen.c...@mediatek.com>; DENG Qingfang <dqf...@gmail.com>;
> Sean Wang <sean.w...@mediatek.com>; Matthias Brugger
> <matthias....@gmail.com>; AngeloGioacchino Del Regno
> <angelogioacchino.delre...@collabora.com>; Linus Walleij
> <linus.wall...@linaro.org>; Alvin Šipraga <a...@bang-olufsen.dk>; Wei Fang
> <wei.f...@nxp.com>; Shenwei Wang <shenwei.w...@nxp.com>; Clark
> Wang <xiaoning.w...@nxp.com>; dl-linux-imx <linux-...@nxp.com>; Lars
> Povlsen <lars.povl...@microchip.com>; Steen Hegelund
> <steen.hegel...@microchip.com>; Daniel Machon
> <daniel.mac...@microchip.com>; unglinuxdri...@microchip.com; Jiawen
> Wu <jiawe...@trustnetic.com>; Mengyuan Lou
> <mengyuan...@net-swift.com>; Heiner Kallweit <hkallwe...@gmail.com>;
> Russell King <li...@armlinux.org.uk>; Alexei Starovoitov <a...@kernel.org>;
> Daniel Borkmann <dan...@iogearbox.net>; Jesper Dangaard Brouer
> <h...@kernel.org>; John Fastabend <john.fastab...@gmail.com>
> Cc: linux-ker...@vger.kernel.org; net...@vger.kernel.org; Nick Desaulniers
> <ndesaulni...@google.com>; Nathan Chancellor <nat...@kernel.org>; Kees
> Cook <keesc...@chromium.org>; intel-wired-...@lists.osuosl.org;
> oss-driv...@corigine.com; linux-hyperv@vger.kernel.org;
> linux-arm-ker...@lists.infradead.org; linux-media...@lists.infradead.org;
> b...@vger.kernel.org; Justin Stitt <justinst...@google.com>
> Subject: [PATCH net-next v5 3/3] net: Convert some ethtool_sprintf() to
> ethtool_puts()
>
> This patch converts some basic cases of ethtool_sprintf() to ethtool_puts().
>
> The conversions are used in cases where ethtool_sprintf() was being used
> with just two arguments:
> | ethtool_sprintf(&data, buffer[i].name);
> or when it's used with format string: "%s"
> | ethtool_sprintf(&data, "%s", buffer[i].name);
> which both now become:
> | ethtool_puts(&data, buffer[i].name);
>
> Signed-off-by: Justin Stitt <justinst...@google.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 4 +-
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index c3b7694a7485..bae9536de767 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2932,10 +2932,10 @@ static void fec_enet_get_strings(struct
> net_device *netdev,
> switch (stringset) {
> case ETH_SS_STATS:
> for (i = 0; i < ARRAY_SIZE(fec_stats); i++) {
> - ethtool_sprintf(&data, "%s", fec_stats[i].name);
> + ethtool_puts(&data, fec_stats[i].name);
> }
> for (i = 0; i < ARRAY_SIZE(fec_xdp_stat_strs); i++) {
> - ethtool_sprintf(&data, "%s", fec_xdp_stat_strs[i]);
> + ethtool_puts(&data, fec_xdp_stat_strs[i]);
> }
> page_pool_ethtool_stats_get_strings(data);
>
Reviewed-by: Wei Fang <wei.f...@nxp.com>
