On Thu, Jul 03, 2025 at 04:44:27PM +0530, Manikanta Guntupalli wrote: Subject needn't binding twice.
dt-bindings: i3c: Add AMD I3C master controller support > Add device tree binding documentation for the AMD I3C master controller. > > The controller is represented by the compatible string "xlnx,axi-i3c-1.0". > The binding specifies required properties including register space, clock, > resets, interrupts and number of i3c target devices, and provides > an example usage. > > Signed-off-by: Manikanta Guntupalli <manikanta.guntupa...@amd.com> > --- > .../devicetree/bindings/i3c/xlnx,axi-i3c.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml > > diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml > b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml > new file mode 100644 > index 000000000000..d4ad3721096f > --- /dev/null > +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i3c/xlnx,axi-i3c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMD I3C master > + > +maintainers: > + - Manikanta Guntupalli <manikanta.guntupa...@amd.com> > + > +description: > + The AXI-I3C IP is an I3C Controller with an AXI4-Lite interface, compatible > + with the MIPI I3C Specification v1.1.1. The design includes bidirectional > I/O > + buffers that implement open collector drivers for the SDA and SCL signals. > + External pull-up resistors are required to properly hold the bus at a > Logic-1 > + level when the drivers are released. > + > +allOf: > + - $ref: i3c.yaml# I perfer put allOf after required, incase need add if-else branch later. > + > +properties: > + compatible: > + const: xlnx,axi-i3c-1.0 > + > + resets: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + xlnx,num-targets: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Number of i3c target devices connected on the bus. > + minimum: 1 > + maximum: 32 > + default: 1 why need this property? i3c is self probe or children nodes in dts. Frank > + > +required: > + - reg > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + i3c@80000000 { > + compatible = "xlnx,axi-i3c-1.0"; > + reg = <0x80000000 0x10000>; > + clocks = <&zynqmp_clk 71>; > + #address-cells = <3>; > + #size-cells = <0>; > + }; > +... > -- > 2.34.1 >
