Add register definitions for components versions and report them during probe.
Reviewed-by: Michal Schmidt <[email protected]> Signed-off-by: Ivan Vecera <[email protected]> --- drivers/mfd/zl3073x-core.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c index 39d4c8608a740..b3091b00cffa8 100644 --- a/drivers/mfd/zl3073x-core.c +++ b/drivers/mfd/zl3073x-core.c @@ -1,10 +1,19 @@ // SPDX-License-Identifier: GPL-2.0-only +#include <linux/bitfield.h> #include <linux/module.h> #include <linux/unaligned.h> #include <net/devlink.h> #include "zl3073x.h" +/* + * Register Map Page 0, General + */ +ZL3073X_REG16_DEF(id, 0x0001); +ZL3073X_REG16_DEF(revision, 0x0003); +ZL3073X_REG16_DEF(fw_ver, 0x0005); +ZL3073X_REG32_DEF(custom_config_ver, 0x0007); + /* * Regmap ranges */ @@ -159,10 +168,36 @@ EXPORT_SYMBOL_NS_GPL(zl3073x_dev_alloc, "ZL3073X"); int zl3073x_dev_init(struct zl3073x_dev *zldev) { + u16 id, revision, fw_ver; struct devlink *devlink; + u32 cfg_ver; + int rc; devm_mutex_init(zldev->dev, &zldev->lock); + scoped_guard(zl3073x, zldev) { + rc = zl3073x_read_id(zldev, &id); + if (rc) + return rc; + rc = zl3073x_read_revision(zldev, &revision); + if (rc) + return rc; + rc = zl3073x_read_fw_ver(zldev, &fw_ver); + if (rc) + return rc; + rc = zl3073x_read_custom_config_ver(zldev, &cfg_ver); + if (rc) + return rc; + } + + dev_info(zldev->dev, "ChipID(%X), ChipRev(%X), FwVer(%u)\n", + id, revision, fw_ver); + dev_info(zldev->dev, "Custom config version: %lu.%lu.%lu.%lu\n", + FIELD_GET(GENMASK(31, 24), cfg_ver), + FIELD_GET(GENMASK(23, 16), cfg_ver), + FIELD_GET(GENMASK(15, 8), cfg_ver), + FIELD_GET(GENMASK(7, 0), cfg_ver)); + devlink = priv_to_devlink(zldev); devlink_register(devlink); -- 2.48.1
