On Mon, Mar 03, 2025 at 01:49:37PM -0800, Kees Cook wrote: > The i386 regparm bug exposed with FORTIFY_SOURCE with Clang was fixed > in Clang 16[1]. > > Link: > https://github.com/llvm/llvm-project/commit/c167c0a4dcdb998affb2756ce76903a12f7d8ca5 > [1] > Signed-off-by: Kees Cook <k...@kernel.org>
Yes, thank you for catching this! Reviewed-by: Nathan Chancellor <nat...@kernel.org> I assume you'll take this? > --- > Cc: Nathan Chancellor <nat...@kernel.org> > Cc: Nick Desaulniers <ndesaulni...@google.com> > Cc: Bill Wendling <mo...@google.com> > Cc: Justin Stitt <justinst...@google.com> > Cc: "Gustavo A. R. Silva" <gustavo...@kernel.org> > Cc: l...@lists.linux.dev > Cc: linux-hardening@vger.kernel.org > --- > security/Kconfig.hardening | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/Kconfig.hardening b/security/Kconfig.hardening > index 23ffb0d7c845..c17366ce8224 100644 > --- a/security/Kconfig.hardening > +++ b/security/Kconfig.hardening > @@ -286,7 +286,7 @@ config FORTIFY_SOURCE > bool "Harden common str/mem functions against buffer overflows" > depends on ARCH_HAS_FORTIFY_SOURCE > # https://github.com/llvm/llvm-project/issues/53645 > - depends on !CC_IS_CLANG || !X86_32 > + depends on !X86_32 || !CC_IS_CLANG || CLANG_VERSION >= 160000 > help > Detect overflows of buffers in common string and memory functions > where the compiler can determine and validate the buffer sizes. > -- > 2.34.1 >
