From: Jeff Xu <jef...@chromium.org>

Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on arm64, covering
the vdso, vvar, and compat-mode vectors and sigpage mappings.

Production release testing passes on Android and Chrome OS.

Signed-off-by: Jeff Xu <jef...@chromium.org>
---
 arch/arm64/Kconfig       |  1 +
 arch/arm64/kernel/vdso.c | 22 +++++++++++++++-------
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index fcdd0ed3eca8..39202aa9a5af 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -38,6 +38,7 @@ config ARM64
        select ARCH_HAS_KEEPINITRD
        select ARCH_HAS_MEMBARRIER_SYNC_CORE
        select ARCH_HAS_MEM_ENCRYPT
+       select ARCH_HAS_MSEAL_SYSTEM_MAPPINGS
        select ARCH_HAS_NMI_SAFE_THIS_CPU_OPS
        select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE
        select ARCH_HAS_NONLEAF_PMD_YOUNG if ARM64_HAFT
diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c
index e8ed8e5b713b..fa3b85b7ff01 100644
--- a/arch/arm64/kernel/vdso.c
+++ b/arch/arm64/kernel/vdso.c
@@ -183,6 +183,7 @@ static int __setup_additional_pages(enum vdso_abi abi,
 {
        unsigned long vdso_base, vdso_text_len, vdso_mapping_len;
        unsigned long gp_flags = 0;
+       unsigned long vm_flags;
        void *ret;
 
        BUILD_BUG_ON(VVAR_NR_PAGES != __VVAR_PAGES);
@@ -197,8 +198,10 @@ static int __setup_additional_pages(enum vdso_abi abi,
                goto up_fail;
        }
 
+       vm_flags = VM_READ|VM_MAYREAD|VM_PFNMAP;
+       vm_flags |= MSEAL_SYSTEM_MAPPINGS_VM_FLAG;
        ret = _install_special_mapping(mm, vdso_base, VVAR_NR_PAGES * PAGE_SIZE,
-                                      VM_READ|VM_MAYREAD|VM_PFNMAP,
+                                      vm_flags,
                                       &vvar_map);
        if (IS_ERR(ret))
                goto up_fail;
@@ -208,9 +211,10 @@ static int __setup_additional_pages(enum vdso_abi abi,
 
        vdso_base += VVAR_NR_PAGES * PAGE_SIZE;
        mm->context.vdso = (void *)vdso_base;
+       vm_flags = VM_READ|VM_EXEC|gp_flags|VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC;
+       vm_flags |= MSEAL_SYSTEM_MAPPINGS_VM_FLAG;
        ret = _install_special_mapping(mm, vdso_base, vdso_text_len,
-                                      VM_READ|VM_EXEC|gp_flags|
-                                      VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC,
+                                      vm_flags,
                                       vdso_info[abi].cm);
        if (IS_ERR(ret))
                goto up_fail;
@@ -326,6 +330,7 @@ arch_initcall(aarch32_alloc_vdso_pages);
 static int aarch32_kuser_helpers_setup(struct mm_struct *mm)
 {
        void *ret;
+       unsigned long vm_flags;
 
        if (!IS_ENABLED(CONFIG_KUSER_HELPERS))
                return 0;
@@ -334,9 +339,10 @@ static int aarch32_kuser_helpers_setup(struct mm_struct 
*mm)
         * Avoid VM_MAYWRITE for compatibility with arch/arm/, where it's
         * not safe to CoW the page containing the CPU exception vectors.
         */
+       vm_flags = VM_READ|VM_EXEC|VM_MAYREAD|VM_MAYEXEC;
+       vm_flags |= MSEAL_SYSTEM_MAPPINGS_VM_FLAG;
        ret = _install_special_mapping(mm, AARCH32_VECTORS_BASE, PAGE_SIZE,
-                                      VM_READ | VM_EXEC |
-                                      VM_MAYREAD | VM_MAYEXEC,
+                                      vm_flags,
                                       &aarch32_vdso_maps[AA32_MAP_VECTORS]);
 
        return PTR_ERR_OR_ZERO(ret);
@@ -345,6 +351,7 @@ static int aarch32_kuser_helpers_setup(struct mm_struct *mm)
 static int aarch32_sigreturn_setup(struct mm_struct *mm)
 {
        unsigned long addr;
+       unsigned long vm_flags;
        void *ret;
 
        addr = get_unmapped_area(NULL, 0, PAGE_SIZE, 0, 0);
@@ -357,9 +364,10 @@ static int aarch32_sigreturn_setup(struct mm_struct *mm)
         * VM_MAYWRITE is required to allow gdb to Copy-on-Write and
         * set breakpoints.
         */
+       vm_flags = VM_READ|VM_EXEC|VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC;
+       vm_flags |= MSEAL_SYSTEM_MAPPINGS_VM_FLAG;
        ret = _install_special_mapping(mm, addr, PAGE_SIZE,
-                                      VM_READ | VM_EXEC | VM_MAYREAD |
-                                      VM_MAYWRITE | VM_MAYEXEC,
+                                      vm_flags,
                                       &aarch32_vdso_maps[AA32_MAP_SIGPAGE]);
        if (IS_ERR(ret))
                goto out;
-- 
2.48.1.601.g30ceb7b040-goog


Reply via email to