On Wed, 19 Feb 2025 14:14:35 +0200 Tariq Toukan wrote: > On 18/02/2025 23:13, Jakub Kicinski wrote: > > On Tue, 18 Feb 2025 17:53:14 +0200 Tariq Toukan wrote: > >> Maybe it wasn't clear enough. > >> We prefer the original patch, and provided the Reviewed-by tag for it. > > > > Can you explain what do you mean by "cleaner"? > > I like the alternative much more. > > Cleaner in the sense that it doesn't touch existing code in en_rx.c > (datapath), and has shorter dereferences for the inner umr_wqe fields, like: > umr_wqe->ctrl > vs. > umr_wqe->hdr.ctrl
IMO that's minor, not sufficient to justify struct_group_tagged()
