On 1. Nov 2024, at 13:26, Andy Shevchenko wrote: > On Fri, Aug 23, 2024 at 04:59:33PM +0200, Thorsten Blum wrote: >> Add the __counted_by compiler attribute to the flexible array member >> attrs to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and >> CONFIG_FORTIFY_SOURCE. >> >> Increment num before adding a new param_attribute to the attrs array and >> adjust the array index accordingly. Increment num immediately after the >> first reallocation such that the reallocation for the NULL terminator >> only needs to add 1 (instead of 2) to mk->mp->num. >> >> Use struct_size() instead of manually calculating the size for the >> reallocation. >> >> Use krealloc_array() for the additional NULL terminator. > > What is / was the resolution on this change? It seems it either fell in cracks > or being abandoned.
There was a false-positive Clang issue with this patch [1] (and other __counted_by() patches) that was mostly discussed here [2]. Clang has since made some changes and there is a patch for the kernel [3]. I'll probably resend this patch once [3] has been merged. Best, Thorsten [1] https://lore.kernel.org/r/20240913164630.GA4091534@thelio-3990X/ [2] https://lore.kernel.org/r/ZvV6X5FPBBW7CO1f@archlinux/ [3] https://lore.kernel.org/r/20241029140036.577804-1-ker...@jfarr.cc/
