On Mon, 21 Oct 2024 13:02:27 -0600 Gustavo A. R. Silva wrote: > Fix 3338 of the following -Wflex-array-member-not-at-end warnings: > > include/linux/ethtool.h:214:38: warning: structure containing a flexible > array member is not at the end of another structure > [-Wflex-array-member-not-at-end]
I don't see any change in the number of warnings with W=1: gcc (GCC) 14.2.1 20240912 (Red Hat 14.2.1-3) Is it only enabled with W=2? > Additionally, update the type of some variables in various functions > that don't access the flexible-array member, changing them to the > newly created `struct ethtool_link_settings_hdr`. Why? Please avoid unnecessary code changes. > include/linux/ethtool.h | 2 +- This is probably where most of the warnings come from. Please split the changes to this header file as a separate patch for ease of review / validation.
