As other rules done, we add rules for str_lo{w}_hi{gh}()
to check the relative opportunities.Signed-off-by: Hongbo Li <lihongb...@huawei.com> --- scripts/coccinelle/api/string_choices.cocci | 46 +++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/scripts/coccinelle/api/string_choices.cocci b/scripts/coccinelle/api/string_choices.cocci index 67818cd6ee09..53fd34a0fcb4 100644 --- a/scripts/coccinelle/api/string_choices.cocci +++ b/scripts/coccinelle/api/string_choices.cocci @@ -177,3 +177,49 @@ e << str_high_low_r.E; @@ coccilib.report.print_report(p[0], "opportunity for str_high_low(%s)" % e) + +@str_lo_hi depends on patch@ +expression E; +@@ +( +- ((E) ? "lo" : "hi") ++ str_lo_hi(E) +) + +@str_lo_hi_r depends on !patch exists@ +expression E; +position P; +@@ +( +* ((E@P) ? "lo" : "hi") +) + +@script:python depends on report@ +p << str_lo_hi_r.P; +e << str_lo_hi_r.E; +@@ + +coccilib.report.print_report(p[0], "opportunity for str_lo_hi(%s)" % e) + +@str_low_high depends on patch@ +expression E; +@@ +( +- ((E) ? "low" : "high") ++ str_low_high(E) +) + +@str_low_high_r depends on !patch exists@ +expression E; +position P; +@@ +( +* ((E@P) ? "low" : "high") +) + +@script:python depends on report@ +p << str_low_high_r.P; +e << str_low_high_r.E; +@@ + +coccilib.report.print_report(p[0], "opportunity for str_low_high(%s)" % e) -- 2.34.1
