On Wed, Aug 07, 2024 at 05:26:02PM +0100, Simon Horman wrote: > On Mon, Aug 05, 2024 at 09:38:08AM -0600, Gustavo A. R. Silva wrote: > > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > > getting ready to enable it, globally. > > > > Move the conflicting declaration to the end of the structure. Notice > > that `struct ethtool_dump` is a flexible structure --a structure that > > contains a flexible-array member. > > > > Fix the following warning: > > ./drivers/net/ethernet/chelsio/cxgb4/cxgb4.h:1215:29: warning: structure > > containing a flexible array member is not at the end of another structure > > [-Wflex-array-member-not-at-end] > > > > Signed-off-by: Gustavo A. R. Silva <gustavo...@kernel.org> > > Reviewed-by: Simon Horman <ho...@kernel.org>
Sorry, one minor nit, after the fact. cxgb4 would probably be a better prefix than ethtool for this patch. But then it would conflict, by name, with - [PATCH] cxgb4: Avoid -Wflex-array-member-not-at-end warning https://lore.kernel.org/all/ZrD8vpfiYugd0cPQ@cute/
