Hi, On Wed, May 08, 2024 at 09:32:20AM +0100, Simon Horman wrote: > Make use of standard helpers to simplify filling in stats strings. > > The first two ethtool_puts() changes address the following fortification > warnings flagged by W=1 builds with clang-18. (The last ethtool_puts > change does not because the warning relates to writing beyond the first > element of an array, and gve_gstrings_priv_flags only has one element.) > > .../fortify-string.h:562:4: warning: call to '__read_overflow2_field' > declared with 'warning' attribute: detected read beyond size of field (2nd > parameter); maybe use struct_group()? [-Wattribute-warning] > 562 | __read_overflow2_field(q_size_field, size); > | ^ > .../fortify-string.h:562:4: warning: call to '__read_overflow2_field' > declared with 'warning' attribute: detected read beyond size of field (2nd > parameter); maybe use struct_group()? [-Wattribute-warning] > > Likewise, the same changes resolve the same problems flagged by Smatch. > > .../gve_ethtool.c:100 gve_get_strings() error: __builtin_memcpy() > '*gve_gstrings_main_stats' too small (32 vs 576) > .../gve_ethtool.c:120 gve_get_strings() error: __builtin_memcpy() > '*gve_gstrings_adminq_stats' too small (32 vs 512) > > Compile tested only. > > Reviewed-by: Shailend Chand <shail...@google.com> > Reviewed-by: Larysa Zaremba <larysa.zare...@intel.com> > Signed-off-by: Simon Horman <ho...@kernel.org>
This patch looks good and follows similar replacements [1] I've made in the past. Acked-by: Justin Stitt <justinst...@google.com> > --- > drivers/net/ethernet/google/gve/gve_ethtool.c | 42 > +++++++++++---------------- > 1 file changed, 17 insertions(+), 25 deletions(-) > > diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c > b/drivers/net/ethernet/google/gve/gve_ethtool.c > index 156b7e128b53..fe1741d482b4 100644 > [1]: https://lore.kernel.org/all/?q=f%3A%22Justin+stitt%22+AND+dfb%3A%22ethtool_puts%22 Thanks Justin
