On 3/26/24 10:41, Alexander Lobakin wrote:
To ease maintaining of virtchnl2.h, which already is messy enough,
make it self-contained by adding missing if_ether.h include due to
%ETH_ALEN usage.
At the same time, virtchnl2_lan_desc.h is not used anywhere in the
file, so remove this include to speed up C preprocessing.

Acked-by: Kees Cook <keesc...@chromium.org>
Signed-off-by: Alexander Lobakin <aleksander.loba...@intel.com>

Acked-by: Gustavo A. R. Silva <gustavo...@kernel.org>

Thanks
--
Gustavo

---
  drivers/net/ethernet/intel/idpf/virtchnl2.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/idpf/virtchnl2.h 
b/drivers/net/ethernet/intel/idpf/virtchnl2.h
index 4a3c4454d25a..29419211b3d9 100644
--- a/drivers/net/ethernet/intel/idpf/virtchnl2.h
+++ b/drivers/net/ethernet/intel/idpf/virtchnl2.h
@@ -4,6 +4,8 @@
  #ifndef _VIRTCHNL2_H_
  #define _VIRTCHNL2_H_
+#include <linux/if_ether.h>
+
  /* All opcodes associated with virtchnl2 are prefixed with virtchnl2 or
   * VIRTCHNL2. Any future opcodes, offloads/capabilities, structures,
   * and defines must be prefixed with virtchnl2 or VIRTCHNL2 to avoid 
confusion.
@@ -17,8 +19,6 @@
   * must remain unchanged over time, so we specify explicit values for all 
enums.
   */
-#include "virtchnl2_lan_desc.h"
-
  /* This macro is used to generate compilation errors if a structure
   * is not exactly the correct length.
   */

Reply via email to