Re: [PATCH v3 2/4] interconnect: qcom: sc7280: enable QoS programming

[Konrad Dybcio]

On 3/6/24 08:30, Odelu Kukatla wrote:

Enable QoS for the master ports with predefined values
for priority and urgency.

Signed-off-by: Odelu Kukatla <quic_okuka...@quicinc.com>
---
  drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++
  1 file changed, 332 insertions(+)

diff --git a/drivers/interconnect/qcom/sc7280.c 
b/drivers/interconnect/qcom/sc7280.c
index 7d33694368e8..1e1002c4d3d8 100644
--- a/drivers/interconnect/qcom/sc7280.c
+++ b/drivers/interconnect/qcom/sc7280.c
@@ -1,6 +1,7 @@
  // SPDX-License-Identifier: GPL-2.0
  /*
   * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
   *
   */

@@ -16,29 +17,53 @@

  #include "icc-rpmh.h"
  #include "sc7280.h"

+static const struct qcom_icc_qosbox qhm_qspi_qos = {

+       .num_ports = 1,
+       .port_offsets = { 0x7000 },
+       .prio = 2,
+       .urg_fwd = 0,
+};
+
  static struct qcom_icc_node qhm_qspi = {
        .name = "qhm_qspi",
        .id = SC7280_MASTER_QSPI_0,
        .channels = 1,
        .buswidth = 4,
+       .qosbox = &qhm_qspi_qos,

        .qosbox = &(const struct qcom_icc_qosbox) {
                .num_ports = 1,
                ...
        },



Looks sensible otherwise

Konrad